Skip to content

docs.rs does not load in China anymore #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Byron opened this issue Aug 16, 2020 · 14 comments · Fixed by #981
Closed

docs.rs does not load in China anymore #979

Byron opened this issue Aug 16, 2020 · 14 comments · Fixed by #981
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug

Comments

@Byron
Copy link
Member

Byron commented Aug 16, 2020

This is what I see when debugging this in Firefox - it appears only a few resources are not loading:

Screenshot 2020-08-16 at 17 49 40

I thought it might be related to the recent move of blocking TLS 1.3 and ESNI, but I couldn't verify it for sure.

I am happy to provide further data to help resolving this issue, if at all possible.
Thank you

@jyn514 jyn514 added A-frontend Area: Web frontend C-bug Category: This is a bug labels Aug 16, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 16, 2020

I guess this is pretty strong motivation for #921. We did switch to fontawesome 5 recently which uses a different CDN, but from your screenshot it looks like even the old files aren't loading.

@jyn514
Copy link
Member

jyn514 commented Aug 16, 2020

Is the site completely broken or is it just the css missing? We can move it from <head> to <body> as a short term workaround which would let you at least use the site.

@jyn514 jyn514 changed the title https://docs.rs does not load in China anymore docs.rs does not load in China anymore Aug 16, 2020
@Byron
Copy link
Member Author

Byron commented Aug 16, 2020

Thanks for taking a look! It's completely broken as one only sees a white screen, due to the CSS not loading. The HTML is present though, it just won't ever be displayed. Firefox would display 'ghosts' of the page while in dev mode for some reason, and Curl can also get anything hosted on docs.rs.

That workaround of moving the CSS sounds great, I would love to give it a try.

@pietroalbini
Copy link
Member

I think vendoring all those files is as easy as shuffling things around, I'd avoid messing with the ordering.

@Kixiron
Copy link
Member

Kixiron commented Aug 16, 2020

If we need to we can vendor our CSS, that's the recommended way to use FA 5

@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

#981 was reverted in production.

@jyn514 jyn514 reopened this Aug 21, 2020
@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

@Byron we redeployed it after the fix in #987 - can you see if docs.rs loads for you now?

@Byron
Copy link
Member Author

Byron commented Aug 21, 2020

@jyn514 YES 🎉! So good to have docs.rs back! It really is a vital piece of the Rust infrastructure! Never thought about it, until now.

Thanks for all of your help to get this fixed!

@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

No problem!

@jyn514 jyn514 closed this as completed Aug 21, 2020
@Byron
Copy link
Member Author

Byron commented Aug 21, 2020

Fun fact: I waited about a week until I reported this issue, assuming it's just something temporary mixed with "somebody else will probably report it first". This makes me question whether I am the only user coming in from China without a VPN.

Do you have statistics on usage by country? VPN users usually come from Hong Kong, otherwise they should be identifiable as coming from mainland China.

@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

Hmm, all our visits are proxied through cloudfront so I don't have access to the statistics, but @pietroalbini or @Mark-Simulacrum might know.

@pietroalbini
Copy link
Member

I'd kinda prefer not to make traffic stats public :(

@Byron
Copy link
Member Author

Byron commented Aug 22, 2020

Interesting stance, I am sure you have a good reason.

Since I am kind of isolated in this country, I have no idea if a Chinese Rust community even exist, and if it does, where they hang out. It's all sealed off from me due to me not speaking/reading the language. By asking this I guess I wanted to feel like there is in fact a community that one fine day, I might even discover :D .

Anyhow, moving on.

@jyn514
Copy link
Member

jyn514 commented Nov 19, 2020

I have no idea if a Chinese Rust community even exist

@Byron you might be interested in https://www.youtube.com/watch?v=j_ha1-1w6sw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants