Update owner details more fully during build and add CLI command to trigger it #917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
suggested changes
Jul 28, 2020
| @@ -167,6 +167,11 @@ impl<'a> FakeRelease<'a> { | |||
| self.source_file("README.md", content.as_bytes()) | |||
| } | |||
|
|
|||
| pub(crate) fn add_owner(mut self, owner: CrateOwner) -> Self { | |||
| self.registry_crate_data.owners.push(owner); | |||
There was a problem hiding this comment.
Hmm ... now I wonder if owners should be a set instead. I guess it doesn't really matter either way since we're using UPSERT.
src/bin/cratesfyi.rs
Outdated
Comment on lines
467
to
471
| db::update_crate_data_in_database( | ||
| &*ctx.conn()?, | ||
| &name, | ||
| &index.api().get_crate_data(&name), | ||
| )?; |
There was a problem hiding this comment.
So, this is ok for now because it's just one or two crates. But when we automate this for the full consistency check, it should use the database dump to avoid spamming the crates.io API. @pietroalbini will not be happy if we make 300k requests in a day 😆
jyn514
approved these changes
Jul 31, 2020
This was referenced Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First two commits improve handling of owner details during a build, if an owners mutable details have been changed since the last time we got them they will be updated in the database, and if an owner has been removed from a crate the relationship will be removed.
Next three commits are cherry-picked from #898, they standardise the prefix handling into the config so that it's easier to correctly load the registry details outside of the
DocBuilder.Final commit adds a CLI command to update the details for a specific crate from the registry API, so that we can solve requests like #158/#837 directly. New (renewed) and existing crates will be fixed automatically when they publish a new version, and doing a mass update of existing bad data should be part of #766, so this should be a temporary command just to solve the problem for users that request it.
fixes #900