Skip to content

Remove crate version from docs.rs #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunjay opened this issue Oct 5, 2017 · 19 comments
Closed

Remove crate version from docs.rs #158

sunjay opened this issue Oct 5, 2017 · 19 comments

Comments

@sunjay
Copy link
Member

sunjay commented Oct 5, 2017

Is there a way to remove certain versions of a crate from docs.rs?

@onur
Copy link
Member

onur commented Oct 6, 2017

Currently there isn't a way to remove crates from docs.rs. I am planning to add a method to check yanked crates and show a warning or remove the crate completely from docs.rs.

For now, I can manually remove the crate if there is an urgency.

@sunjay
Copy link
Member Author

sunjay commented Oct 6, 2017

Could you remove the yanked versions of the turtle crate? That's currently all the versions.

Thanks

@pravic
Copy link

pravic commented Sep 1, 2018

@jyn514
Copy link
Member

jyn514 commented Feb 1, 2020

We've since redirected the docs for yanked crates for the latest version. It would be nice to add a badge saying that the crate has been yanked e.g. on https://docs.rs/crate/futures/0.2.3-docs-yank.4.

@jyn514
Copy link
Member

jyn514 commented Feb 1, 2020

Oops, I think that might have been done by futures in their docs actually. We have a long way to go for handling yanks 😅

See also #112, #322 , #561

@Nemo157
Copy link
Member

Nemo157 commented May 6, 2020

@sunjay with #614 fixed so that the yanked status of 0.1.* is updated, do you still want the docs fully removed? The old versions show warnings that they are yanked and suggest redirecting to the prereleases.

@sunjay
Copy link
Member Author

sunjay commented May 6, 2020

@sunjay with #614 fixed so that the yanked status of 0.1.* is updated, do you still want the docs fully removed?

Yes, that would be great. Those versions were for a different crate that used to use that name. Removing them will avoid some confusion so please do that. Thanks!

@jyn514 jyn514 changed the title Remove crate from docs.rs Remove crate version from docs.rs May 6, 2020
@jyn514
Copy link
Member

jyn514 commented May 6, 2020

We have a way to delete entire crates (delete-crate), but it sounds like you're asking for specific versions to be removed which is a little harder.

@sunjay
Copy link
Member Author

sunjay commented May 6, 2020

Yes. I only want the 0.x versions removed. Back when this issue was created those were the only versions. 😅

@pietroalbini
Copy link
Member

I'm wondering if we should just hide the documentation of all yanked crates.

@jyn514
Copy link
Member

jyn514 commented May 6, 2020

Currently what we do is we don't show them unless you explicitly go to the link, and all the links to it have a big warning sign in addition to the 'this crate has been yanked' banner.

image

image

We could also hide the link to the yanked version if you like, but I'm starting to question how applicable this is to other use cases, it seems a little specific to turtle.

@sunjay
Copy link
Member Author

sunjay commented May 6, 2020

Yeah I'd be fine with them just being deleted for the turtle crate. I can see why building something more general might cause unexpected issues.

@Kixiron
Copy link
Member

Kixiron commented May 7, 2020

I'm not necessarily against hiding (and potentially deleting, we need to do an audit of how much space is taken up by yanked crates) yanked docs, but it'll inevitably bring up the question/objection that we aren't supposed to be the ones who decide that docs aren't shown. Like I said, I'm not against it though, as I personally feel like someone who's using yanked crates can be reasonably expected to build docs locally and I think it'd get rid of what is basically a class of issues and considerations that have to come up so often

@jyn514
Copy link
Member

jyn514 commented Jul 18, 2020

I have deleted all the 0.x versions of turtle. The previous owner still shows up though (#900), that's waiting on #766.

@rust-lang rust-lang locked as spam and limited conversation to collaborators Jul 18, 2020
@jyn514
Copy link
Member

jyn514 commented Jul 18, 2020

Sorry for the spam from rustbot, I've reached out to the infra team to fix it. In the meantime feel free to reach out to us on Discord: https://discord.gg/f7mTXPW

@rust-lang rust-lang unlocked this conversation Jul 18, 2020
@pietroalbini
Copy link
Member

I'm scared of commenting now.

@rust-lang rust-lang locked as spam and limited conversation to collaborators Jul 18, 2020
@Mark-Simulacrum
Copy link
Member

Even if we delete rustbot's messages github will steal leave a bunch of "message deleted" markers -- it might be easier to just open a new issue to track this. I'll leave it up to @jyn514 (or docs.rs team in general) though -- on triagebot's end things should be fixed now.

@rust-lang rust-lang unlocked this conversation Jul 19, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@ghost ghost deleted a comment from rustbot Jul 20, 2020
@jyn514
Copy link
Member

jyn514 commented Jul 31, 2020

I removed the old owner from turtle.

@jyn514 jyn514 closed this as completed Jul 31, 2020
@sunjay
Copy link
Member Author

sunjay commented Jul 31, 2020

Thanks for all your help @jyn514!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants