Skip to content

Add an option to delete versions of a crate #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 16, 2020

Closes #528.
Allows closing #837 and #158.
Makes #368 much easier.
Makes #766 more useful.

r? @pietroalbini

jyn514 added 2 commits July 15, 2020 21:56
- Test for authors in delete_version
- Enforce that table_name and column_name are hard-coded
@jyn514
Copy link
Member Author

jyn514 commented Jul 16, 2020

This is best reviewed commit-by-commit since I renamed delete_crate.rs.

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good! Thanks for working on this ❤️

There is now less risk of misuse.
@pietroalbini
Copy link
Member

Feel free to merge once CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable removal/access restriction for specific versions of a crate, rather than the entire crate
2 participants