don't delete full crates from docs.rs when only a version was deleted #2163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
force-pushed
the
fix-version-delete
branch
from
3c94cc0 to
822811a
Compare
|
With the new release of |
syphar
force-pushed
the
fix-version-delete
branch
from
822811a to
efe3d0e
Compare
syphar
force-pushed
the
fix-version-delete
branch
from
efe3d0e to
538c0ff
Compare
Byron
approved these changes
Jul 4, 2023
syphar
added
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to https://rust-lang.zulipchat.com/#narrow/stream/356853-t-docs-rs/topic/glium.20gone
where we delete all releases for a crate while only one or more releases were deleted.
This was coming at least from a bug in the crates-index-diff docs: https://docs.rs/crates-index-diff/latest/crates_index_diff/enum.Change.html where it also emits
Deletedfor a version-delete, not only a crate-delete.Draft PR for a fix: Byron/crates-index-diff-rs#38