Skip to content

split VersionDeleted from crate-deletes #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

@syphar
Copy link
Contributor Author

syphar commented Jul 4, 2023

@Byron what do you think about this?

Alternatively, we could also adapt the documentation, though I believe that crates-index-diff is in a better position to differentiate between crate- and version-deletes than docs.rs :)

@Byron
Copy link
Owner

Byron commented Jul 4, 2023

I think this is the change I would have wanted as well! Sorry for having let the Deleted variant slide into strange behaviour there, it's clearly misleading the way it's implemented :/.

Let me see that I can get this PR ready for being merged and create a new release.

@Byron Byron merged commit 2c59dd4 into Byron:main Jul 4, 2023
@Byron
Copy link
Owner

Byron commented Jul 4, 2023

And here is the new release.

@syphar syphar deleted the version-delete branch July 4, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants