Skip to content

Don't execute a build when not enough memory is available #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

Don't execute a build when not enough memory is available #1279

merged 1 commit into from
Feb 16, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Feb 15, 2021 •
edited
Loading

Example error:

2021/02/15 01:43:12 [INFO] docs_rs::docbuilder::rustwide_builder: building package regex 1.3.1
Error: Building documentation failed

Caused by:
    not enough memory to build regex 1.3.1: needed 3072 MiB, have 2909 MiB
help: set DOCSRS_DISABLE_MEMORY_LIMIT=true to force a build

Fixes #657.

r? @pietroalbini or @Nemo157

@jyn514 jyn514 added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed A-builds Area: Building the documentation for a crate A-admin Area: Administration of the production docs.rs server labels Feb 15, 2021
@Nemo157
Copy link
Member

Nemo157 commented Feb 15, 2021

Don't queue a build [...]

Or "dequeue a build" ?

Nemo157
Nemo157 reviewed Feb 15, 2021
View reviewed changes
@jyn514 jyn514 changed the title Don't queue a build when not enough memory is available Don't execute a build when not enough memory is available Feb 15, 2021
@jyn514
Don't execute a build when not enough memory is available
df50879 
Example error:

```
2021/02/15 01:43:12 [INFO] docs_rs::docbuilder::rustwide_builder: building package regex 1.3.1
Error: Building documentation failed

Caused by:
    not enough memory to build regex 1.3.1: needed 3072 MiB, have 2909 MiB
help: set DOCSRS_DISABLE_MEMORY_LIMIT to force a build
```
@jyn514 jyn514 merged commit f561456 into rust-lang:master Feb 16, 2021
@jyn514 jyn514 deleted the not-enough-ram branch February 16, 2021 19:15
@jyn514 jyn514 mentioned this pull request Apr 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Nemo157 Nemo157 Nemo157 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-admin Area: Administration of the production docs.rs server A-builds Area: Building the documentation for a crate S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs.rs starts building a crate even when there is not enough RAM
2 participants
@jyn514 @Nemo157