Update .env-sample #941
Merged
Update .env-sample #941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
requested changes
Aug 9, 2017
.env.sample
Outdated
| @@ -7,8 +7,8 @@ export DATABASE_URL= | |||
| # export MIRROR=1 | |||
|
|
|||
| # Key to sign and encrypt cookies with. Change this to a long, random string | |||
| # for production. | |||
| export SESSION_KEY=badkey | |||
| # that is at least 32 bytes for production | |||
There was a problem hiding this comment.
Weren't you seeing dev not able to start if this wasn't at least 32 bytes all the time? So I think this should be split up differently, so that "32 bytes" isn't connected to "for production". Something like:
# Key to sign and encrypt cookies with. Must be at least 32 bytes. Change this
# to a long, random string for production.
?
carols10cents
approved these changes
Aug 14, 2017
|
bors: r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also addresses #937 and add notes for #909 in the .env-sample. Also decided to fix up an issue which we sometimes ran into with the
S3_GLOBALvariable, which was noted in the CONTRIBUTING.md. I thusly removed those notes from there too :).