Merge #941

941: Update .env-sample r=carols10cents

Also addresses #937 and add notes for #909 in the .env-sample. Also decided to fix up an issue which we sometimes ran into with the `S3_GLOBAL` variable, which was noted in the CONTRIBUTING.md. I thusly removed those notes from there too :).

Author: bors-voyager[bot]

.env.sample

@@ -6,9 +6,9 @@ export DATABASE_URL=
 # If you are running a mirror of crates.io, uncomment this line.
 # export MIRROR=1
 
-# Key to sign and encrypt cookies with. Change this to a long, random string
-# for production.
-export SESSION_KEY=badkey
+# Key to sign and encrypt cookies with. Must be at least 32 bytes. Change this 
+# to a long, random string for production.
+export SESSION_KEY=badkeyabcdefghijklmnopqrstuvwxyzabcdef
 
 # If you will be running the tests, set this to another database that you
 # have created. For example, if your test database is named
@@ -22,7 +22,8 @@ export TEST_DATABASE_URL=
 # export S3_BUCKET=
 # export S3_ACCESS_KEY=
 # export S3_SECRET_KEY=
-# export S3_REGION=      # not needed if the S3 bucket is in US standard
+# not needed if the S3 bucket is in US standard
+# export S3_REGION=
 
 # Remote and local locations of the registry index. You can leave these to
 # use a `tmp` subdirectory of the working directory, which is what the

docs/CONTRIBUTING.md

@@ -316,27 +316,6 @@ with `CTRL-C` and rerun this command every time you change the backend code):
 cargo run --bin server
 ```
 
-> If you get an error that looks like:
->
-> ```
-> thread 'main' panicked at 'must have `GIT_REPO_URL` defined', src/lib.rs:227
-> ```
->
-> Edit your `.env` and remove the comment after the `S3_REGION` variable. That
-> is, change this:
->
-> ```
-> export S3_REGION=      # not needed if the S3 bucket is in US standard
-> ```
->
-> to this:
->
-> ```
-> export S3_REGION=
-> ```
->
-> and then try running `cargo run --bin server` again.
-
 Then start a frontend that uses this backend by running this command in another
 terminal session (the frontend picks up frontend changes using live reload
 without a restart needed, and you can leave the frontend running while you