Validate email addresses before saving them to the database #9365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#921 introduced a way for users to change their registered email addresses, but the code in the PR did not check if the supplied email addresses are valid and only relied on the email verification process. This led us to having about two dozens "email addresses" in our database now that aren't actually valid email addresses (e.g. people replacing
@
with[at]
and other fun examples).This PR passes the supplied email address to a
.parse::<lettre::Address>()
call and returns an HTTP error if the supplied email is invalid.