Skip to content

Doc comments on new pull requests #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2017
Merged

Doc comments on new pull requests #920

merged 1 commit into from
Jul 30, 2017

Conversation

vignesh-sankaran
Copy link
Contributor

Along the lines of #899, we should start mandating doc comments on all new types and functions, and encourage doc comments on modified types.

Is there a way to check for this in TravisCI as well?

@carols10cents
Copy link
Member

carols10cents commented Jul 29, 2017 •
edited
Loading

Once we have everything documented, we can add #![deny(missing_doc)] to src/lib.rs to make sure docs get added to new items :)

bors-voyager bot added a commit that referenced this pull request Jul 29, 2017
@bors-voyager
Merge #920
7bec5d8 
920: Doc comments on new pull requests r=carols10cents

Along the lines of #899, we should start mandating doc comments on all new types and functions, and encourage doc comments on modified types. 

Is there a way to check for this in TravisCI as well?
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Jul 30, 2017

Timed out

@carols10cents
Copy link
Member

bors retry

@carols10cents
Copy link
Member

bors r+

bors-voyager bot added a commit that referenced this pull request Jul 30, 2017
@bors-voyager
Merge #920
120f800 
920: Doc comments on new pull requests r=carols10cents

Along the lines of #899, we should start mandating doc comments on all new types and functions, and encourage doc comments on modified types. 

Is there a way to check for this in TravisCI as well?
@bors-voyager
Copy link
Contributor

bors-voyager bot commented Jul 30, 2017

Build succeeded

@bors-voyager bors-voyager bot merged commit 9a16101 into rust-lang:master Jul 30, 2017
@vignesh-sankaran vignesh-sankaran deleted the update-contributing branch August 1, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vignesh-sankaran @carols10cents