Remove unused code for download button #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgeibel
force-pushed
the
remove-download-from-frontend
branch
from
396c068 to
ff7f12a
Compare
locks
approved these changes
Jul 26, 2017
|
bors r+ |
|
hmmm |
The button was originally removed in rust-lang#15 and rust-lang#18
carols10cents
force-pushed
the
remove-download-from-frontend
branch
from
ff7f12a to
1aecb45
Compare
|
bors r+ |
|
bors-voyager r+ |
|
Hey, looks awesome! I read about bors-ng recently. So it looks like this is testing on travis-ci now and will be automatically merged if the build passes, right? |
|
That's the theory :) Still working out a few kinks-- I deployed an instance of bors-ng to https://bors-voyager.herokuapp.com/ and I don't think i have it right yet... |
|
bors r+ |
|
THERE WE GO! |
|
It looks like it started a build for staging and staging.tmp. The staging.tmp branch doesn't exist but it looks like staging is still building fine. |
Build succeeded |
|
Yay, awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download button has not been available since pre rust-1.0. The button was originally commented out in #15 and #18.