Skip to content

Manual download has weird affect on stats in UI #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gankra opened this issue Oct 28, 2014 · 2 comments
Closed

Manual download has weird affect on stats in UI #18

Gankra opened this issue Oct 28, 2014 · 2 comments

Comments

@Gankra
Copy link
Contributor

Gankra commented Oct 28, 2014

In the browser UI, it uses JS to update the counter. But if you refresh the page the counter goes back down.

Also I'm not sure if this was a coincidence or not, but once I did a download by depending in a project, it seemed to only then register the manual download. Future manual/programmatic downloads seem to be eaten, but that might be cargo being smart enough to notice the same user/browser/ip/project re-requesting it.

(testing with the dining philosophers package)

@Gankra
Copy link
Contributor Author

Gankra commented Oct 28, 2014

Edit: the coincidence was the other issue I submitted triggered the alex chricton process to do a manual update.

@Gankra Gankra changed the title Manual download has weird affect on stats Manual download has weird affect on stats in UI Oct 28, 2014
@alexcrichton
Copy link
Member

Ah yeah I have a bit of JS wizardry to bump the counter whenever you manually hit the download link (b/c you'd kinda expect the number to get bumped). It may be over the top though.

jtgeibel added a commit to jtgeibel/crates.io that referenced this issue Jul 26, 2017
The button was originally removed in rust-lang#15 and rust-lang#18
jtgeibel added a commit to jtgeibel/crates.io that referenced this issue Jul 26, 2017
The button was originally removed in rust-lang#15 and rust-lang#18
carols10cents pushed a commit to jtgeibel/crates.io that referenced this issue Jul 29, 2017
The button was originally removed in rust-lang#15 and rust-lang#18
bors-voyager bot added a commit that referenced this issue Jul 29, 2017
916: Remove unused code for download button r=carols10cents

The download button has not been available since pre rust-1.0.  The button was originally commented out in #15 and #18.
Turbo87 pushed a commit that referenced this issue Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants