Skip to content

Port categories/slugs over to Diesel #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2017

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Jun 6, 2017

No description provided.

@sgrif sgrif force-pushed the sg-port-category-slugs branch 3 times, most recently from 359d405 to 3736001 Compare July 6, 2017 00:30
let rows = stmt.query(&[])?;
let conn = req.db_conn()?;
let slugs = categories::table
.select((categories::slug, categories::slug))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like the order by to ensure that the slugs are alphabetical, please :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol wtf why did I write this

@sgrif sgrif force-pushed the sg-port-category-slugs branch from 3736001 to b87d7b2 Compare July 8, 2017 12:06
@sgrif
Copy link
Contributor Author

sgrif commented Jul 8, 2017

Updated and added a test for this endpoint.

@carols10cents carols10cents force-pushed the sg-port-category-slugs branch from c15c897 to e664df5 Compare July 8, 2017 14:44
Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased since I changed some things out from under you :) This looks great now, just waiting for travis to go green then I'll merge!

@sgrif
Copy link
Contributor Author

sgrif commented Jul 8, 2017

Failure was just rustfmt. I fixed, going to go ahead and merge

@sgrif sgrif merged commit ceae004 into rust-lang:master Jul 8, 2017
@sgrif sgrif deleted the sg-port-category-slugs branch July 8, 2017 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants