Use a temp table for encode_many #6
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just using IN will be faster for small numbers of crates, so you might want to switch implementations depending on crates.len(). The best solution would be to use COPY, but I haven't implemented that yet. I haven't actually tested this, but it compiles!
| let mut query = "INSERT INTO crateids (id) VALUES (".to_string(); | ||
| let mut crateids: Vec<&ToSql> = vec![]; | ||
| for (i, krate) in crates.iter().enumerate() { | ||
| query.push_str(format!("${}", i+1).as_slice()); |
There was a problem hiding this comment.
Is this meant to build a query that looks like ... VALUES ($1$2$3...$n) ... or should there be spaces/commas too?
There was a problem hiding this comment.
Also, this could theoretically use a writer to avoid the format! temporary strings.
There was a problem hiding this comment.
Fixed that as well, thanks
|
BTW, bad things will happen if |
|
For now that list should always be small enough (on the order of at most 100), so I don't think we need this quite yet. That being said, this is a pretty slick way to do thing that I've never heard of before! I'll be sure to remember this for later queries, thanks @sfackler! |
Turbo87
pushed a commit
that referenced
this pull request
Dec 8, 2022
Bump to latest conduit alpha and use `http` types
Turbo87
pushed a commit
that referenced
this pull request
Jan 4, 2023
Bump to latest conduit alpha and use `http` types
Turbo87
pushed a commit
that referenced
this pull request
Jan 4, 2023
Bump to latest conduit alpha and use `http` types
Turbo87
pushed a commit
that referenced
this pull request
Jan 4, 2023
Add support for changes to `conduit::Body`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just using IN will be faster for small numbers of crates, so you might
want to switch implementations depending on crates.len(). The best
solution would be to use COPY, but I haven't implemented that yet.
I haven't actually tested this, but it compiles!