Skip to content

Sort optional dependencies last #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2017
Merged

Sort optional dependencies last #573

merged 1 commit into from
Mar 4, 2017

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Feb 23, 2017

fixes #527

@carols10cents
Copy link
Member

Just curious, why does the ORDER BY include crate_id too?

@Eh2406
Copy link
Contributor Author

Eh2406 commented Mar 1, 2017

No really good reason. While I am removing arbitrary ordering, may as well do it hear. Alphabetical is easy and better than arbitrary. But I am not strongly wedded to it.

@carols10cents
Copy link
Member

Yeah, I think alphabetical by name would make more sense. Mind making that change? Thanks!

@Eh2406
Copy link
Contributor Author

Eh2406 commented Mar 1, 2017

I was assuming order by crate_id and order by name would be similar. I will go look at the schema to determine if crates or dependencies has a name. Then to make the switch.

@Eh2406
Copy link
Contributor Author

Eh2406 commented Mar 1, 2017

switched and rebased.

@carols10cents carols10cents merged commit 63ca88c into rust-lang:master Mar 4, 2017
@carols10cents
Copy link
Member

Awesome, thank you!!! ☃️

@Eh2406 Eh2406 deleted the fix527 branch March 8, 2017 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort optional dependencies last
2 participants
@Eh2406 @carols10cents