Fix intermittent badge::update_crate. #547
Conversation
Introduced in 4ce099b. Closes rust-lang#546.
|
The first commit should fix the intermittent failures bug but I got frustrated when I was extending these badge tests originally because it was all one big test with a lot of continuing state throughout the test. I added the second commit (which I'll be fixing tonight) to break these up into better stop understand tests. There were also some things that weren't properly tested in the old huge test (like a test for adding an appveyor badge without a required field), so I added those tests in this refactoring. If you'd rather I break them out as a separate commit I can do that as well. |
|
I'm fine having it in the same PR, I'm just not going to merge it til you've got the tests passing, whenever you have a chance is fine! :) |
|
Will do, now that you documented the pgsql stuff (thanks, btw!), I'll get the tests working locally instead of trying to just use Travis to do everything! Very slow that way. |
Correct capitalization of GitLab Never realized this is how they spelled it when I added these docs. Equivalent changes are pending for `crates.io` in rust-lang/crates.io#547
|
@carols10cents got tests working locally which sped things up and I think this PR should be good to go. I snuck in a GitLab capitalization fix that is also necessary. |
|
Awesome, looks great! |
Failure introduced in 4ce099b.
Closes #546