Skip to content

Nightly build broke #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carols10cents opened this issue Feb 6, 2017 · 1 comment
Closed

Nightly build broke #546

carols10cents opened this issue Feb 6, 2017 · 1 comment
Assignees
@carols10cents

Comments

@carols10cents
Copy link
Member

Not entirely sure why because the PRs all passed, but i'll look into it tonight.

https://travis-ci.org/rust-lang/crates.io/builds/198708315
@carols10cents carols10cents self-assigned this Feb 6, 2017
@LeopoldArkham
Copy link
Contributor

LeopoldArkham commented Feb 6, 2017 •
edited
Loading

It looks like the only problem is that the DB is updated from a hashmap with no fixed order, but the failing test makes a comparison with a fixed-order Vec. The test on the PR probably got lucky on the order, since there are only two elements!

CC @Susurrus, just testing with .contains() should do it.

Susurrus added a commit to Susurrus/crates.io that referenced this issue Feb 7, 2017
@Susurrus
Fix intermittent badge::update_crate.
f8a0948 
Introduced in 4ce099b.

Closes rust-lang#546
@Susurrus Susurrus mentioned this issue Feb 7, 2017
Merged
Susurrus added a commit to Susurrus/crates.io that referenced this issue Feb 7, 2017
@Susurrus
Fix intermittent badge::update_crate failures
556dcff 
Introduced in 4ce099b.

Closes rust-lang#546.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carols10cents carols10cents

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carols10cents @LeopoldArkham