Skip to content

Add support for keyword:cli and category:no-std search filters #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 20, 2022

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 28, 2021

Resolves #491

These filters can be used standalone, or combined with regular search terms. The syntax is inspired by https://api-docs.npms.io

Bildschirmfoto 2021-12-29 um 00 16 37 Bildschirmfoto 2021-12-29 um 00 18 00

@Turbo87 Turbo87 added A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Dec 28, 2021
@Turbo87 Turbo87 requested review from locks and pichfl December 28, 2021 23:18
@Turbo87 Turbo87 force-pushed the enhanced-search branch 3 times, most recently from 81e71df to ba55528 Compare January 2, 2022 10:13
@Turbo87
Copy link
Member Author

Turbo87 commented Jan 7, 2022

we have discussed this PR in the weekly team meeting today and there were no objections on the general functionality.

one thing left to do is remove support for the keywords:foo,bar syntax and only keep the singular keyword:foo keyword:bar for now.

@Turbo87 Turbo87 force-pushed the enhanced-search branch 2 times, most recently from 32fca71 to 57a81fc Compare January 9, 2022 20:09
@pietroalbini
Copy link
Member

There should probably be a warning if someone adds multiple categories, other than that r=me.

@Turbo87 Turbo87 force-pushed the enhanced-search branch 2 times, most recently from fe5c311 to 9c43a10 Compare January 20, 2022 19:14
@Turbo87
Copy link
Member Author

Turbo87 commented Jan 20, 2022

There should probably be a warning if someone adds multiple categories

✅ done

@bors r=pietroalbini

@bors
Copy link
Contributor

bors commented Jan 20, 2022

📌 Commit 2144fca has been approved by pietroalbini

@bors
Copy link
Contributor

bors commented Jan 20, 2022

⌛ Testing commit 2144fca with merge 82105a9...

@bors
Copy link
Contributor

bors commented Jan 20, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 82105a9 to master...

@bors bors merged commit 82105a9 into rust-lang:master Jan 20, 2022
@Turbo87 Turbo87 deleted the enhanced-search branch January 20, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to search within a keyword or category
3 participants