Skip to content

Commit 32fca71

Browse files
committed
processSearchQuery: Remove support for keywords: filter
as discussed in the team meeting
1 parent a2df96b commit 32fca71

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

app/utils/search.js

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
const CATEGORY_PREFIX = 'category:';
22
const KEYWORD_PREFIX = 'keyword:';
3-
const KEYWORDS_PREFIX = 'keywords:';
43

54
/**
6-
* Process a search query string and extract filters like `keywords:`.
5+
* Process a search query string and extract filters like `keyword:`.
76
*
87
* @param {string} query
98
* @return {{ q: string, keyword?: string, all_keywords?: string, category?: string }}
@@ -25,12 +24,6 @@ export function processSearchQuery(query) {
2524
if (value) {
2625
keywords.push(value);
2726
}
28-
} else if (token.startsWith(KEYWORDS_PREFIX)) {
29-
keywords = token
30-
.slice(KEYWORDS_PREFIX.length)
31-
.split(',')
32-
.map(it => it.trim())
33-
.filter(Boolean);
3427
} else {
3528
queries.push(token);
3629
}

tests/utils/search-test.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,16 +6,14 @@ module('processSearchQuery()', function () {
66
const TESTS = [
77
['foo', { q: 'foo' }],
88
[' foo bar ', { q: 'foo bar' }],
9-
['foo keywords:bar', { q: 'foo', keyword: 'bar' }],
10-
['foo keywords:', { q: 'foo' }],
11-
['keywords:bar foo', { q: 'foo', keyword: 'bar' }],
12-
['foo \t keywords:bar baz', { q: 'foo baz', keyword: 'bar' }],
13-
['foo keywords:bar,baz', { q: 'foo', all_keywords: 'bar baz' }],
14-
['foo keywords:bar keywords:baz', { q: 'foo', keyword: 'baz' }],
9+
['foo keyword:bar', { q: 'foo', keyword: 'bar' }],
10+
['foo keyword:', { q: 'foo' }],
11+
['keyword:bar foo', { q: 'foo', keyword: 'bar' }],
12+
['foo \t keyword:bar baz', { q: 'foo baz', keyword: 'bar' }],
1513
['foo keyword:bar keyword:baz', { q: 'foo', all_keywords: 'bar baz' }],
1614
['foo category:', { q: 'foo' }],
1715
['foo category:no-std', { q: 'foo', category: 'no-std' }],
18-
['foo category:no-std keywords:bar,baz', { q: 'foo', all_keywords: 'bar baz', category: 'no-std' }],
16+
['foo category:no-std keyword:bar keyword:baz', { q: 'foo', all_keywords: 'bar baz', category: 'no-std' }],
1917
];
2018

2119
for (let [input, expectation] of TESTS) {

0 commit comments

Comments
 (0)