Split logged instance metrics into multiple lines when necessary #3690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heroku has a limit for log lines of 10,000 bytes, and when a line reaches that size the platform will automatically split it into multiple lines, breaking the tooling reading it. To avoid that problem when outputting metrics, this commit implements the splitting on the application side when a line is longer than 5,000 bytes. The threshold is just 5,000 because the newline is inserted *after* the item that made the line too long, so it's possible that the actual lines will be longer than 5,000 bytes.
|
r? @smarnach (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit 7604682 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heroku has a limit for log lines of 10,000 bytes, and when a line reaches that size the platform will automatically split it into multiple lines, breaking the tooling reading it.
To avoid that problem when outputting metrics, this commit implements the splitting on the application side when a line is longer than 5,000 bytes. The threshold is just 5,000 because the newline is inserted after the item that made the line too long, so it's possible that the actual lines will be longer than 5,000 bytes.
Fixes #3689.