Header: Use custom focus styling #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current focus outline is using a rectangle, while the input is rounded, which looks very ugly. This commit uses a `box-shadow` instead of the regular `outline` to solve this issue.
locks
reviewed
Dec 6, 2020
| transition: box-shadow 150ms; | ||
|
|
||
| &:focus { | ||
| outline: none; |
There was a problem hiding this comment.
does this not mess with accessibility?
There was a problem hiding this comment.
only if there is no visual alternative, which the shadow provides in this case
|
@bors r+ |
|
📌 Commit 8f3b07f has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current focus outline is using a rectangle, while the input is rounded, which looks very ugly. This commit uses a
box-shadowinstead of the regularoutlineto solve this issue.Before:
After:
r? @locks