Skip to content

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Apr 10, 2020

If an error was thrown without an errors property the error handler would crash, and if the error had such a property but without the "Not Found" detail the error would still not be shown because it wasn't rethrown.

r? @locks

@Turbo87 Turbo87 added A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Apr 10, 2020
@locks
Copy link
Contributor

locks commented Apr 10, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 10, 2020

📌 Commit 0951a52 has been approved by locks

@bors
Copy link
Contributor

bors commented Apr 10, 2020

⌛ Testing commit 0951a52 with merge 06c8e2a...

@bors
Copy link
Contributor

bors commented Apr 10, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing 06c8e2a to master...

@bors bors merged commit 06c8e2a into rust-lang:master Apr 10, 2020
@Turbo87 Turbo87 deleted the crate-error branch April 10, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants