Fixing issues with owner invites and renamed accounts #2177
Conversation
|
r? @sgrif (rust_highfive has picked a reviewer for you, use r? to override) |
|
Since you're looking into this, #1586 is still open and goes after the deeper problem, which is more than just owner invites |
|
Yep, it'd be great if you'd rebase that PR and address the comments smarnarch left! AFAICT the test I've added in this PR would still fail on that branch, though, so to fix the immediate problem a user is experiencing, that PR won't help. |
Accounts where the gh_id is -1 are accounts we know are inactive and should never be invited to own crates
Assuming gh_id always increases, if we have multiple users with the same gh_login, the one with the higher id is the most recently valid account we know about
|
I'm happy to squash the format commit in before merging, but didn't want to mess up the test result demonstrations I already did. This is ready for review now; see email for context. |
|
Okay, I finally understand the subset of accounts this applies to and how it relates to the other PR. This looks good to me. @bors r+ |
|
📌 Commit 61c840b has been approved by |
|
☀️ Test successful - checks-travis |
Pushing commit by commit to demonstrate test failures and fixes