Skip to content

Split up styles into per-route/component style files #2109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 9, 2020

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jan 9, 2020

This makes the styles of a component/route a lot easier to find and maintain.

I would like to eventually use https://github.com/salsify/ember-css-modules for this project, which will ensure proper scoping too.

r? @locks

@locks
Copy link
Contributor

locks commented Jan 9, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jan 9, 2020

📌 Commit 7f5c164 has been approved by locks

@bors
Copy link
Contributor

bors commented Jan 9, 2020

⌛ Testing commit 7f5c164 with merge 2192bb3...

bors added a commit that referenced this pull request Jan 9, 2020
Split up styles into per-route/component style files

This makes the styles of a component/route a lot easier to find and maintain.

I would like to eventually use https://github.com/salsify/ember-css-modules for this project, which will ensure proper scoping too.

r? @locks
@bors
Copy link
Contributor

bors commented Jan 9, 2020

☀️ Test successful - checks-travis
Approved by: locks
Pushing 2192bb3 to master...

@bors bors merged commit 7f5c164 into rust-lang:master Jan 9, 2020
@Turbo87 Turbo87 deleted the style-files branch March 30, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants