Remove jQuery from hashchange.js and controllers #1780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rwjblue
reviewed
Jul 9, 2019
app/initializers/hashchange.js
Outdated
| @@ -29,11 +27,17 @@ function hashchange() { | |||
| } | |||
|
|
|||
| export function initialize() { | |||
| $(window).on('hashchange', hashchange); | |||
| if (typeof window.addEventListener === 'undefined') { | |||
There was a problem hiding this comment.
I think you will also need a typeof window !== 'undefined' guard here to work well in FastBoot. AFAICT you basically never need to run this initializer in SSR modes.
locks
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.