Skip to content

Crate list: Add rounded corners #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Crate list: Add rounded corners #172

wants to merge 1 commit into from

Conversation

CruzBishop
Copy link
Contributor

They didn't look quite right exactly rounded, so this is slightly different to normal.

Feel free to reject this if you want them to remain square or rounded normally, it's just an experiment.

Screenshot of dev version

Signed-off-by: Cruz Julian Bishop <[email protected]>
@alexcrichton
Copy link
Member

Thanks for the PR! I'm somewhat hesitant to merge small stylistic updates like this as we probably just want a larger overhaul and thes ends up being inconsistent with a number of the other styles found on the site.

@CruzBishop
Copy link
Contributor Author

Fair enough. If you'd like, I could just go around and make one large PR
that adds similarly styled corners everywhere, or were you thinking of more
of an internal discussion -> RFC -> theme refresh?

On Sun, Jul 26, 2015 at 3:24 AM, Alex Crichton [email protected]
wrote:

Thanks for the PR! I'm somewhat hesitant to merge small stylistic updates
like this as we probably just want a larger overhaul and thes ends up being
inconsistent with a number of the other styles found on the site.


Reply to this email directly or view it on GitHub
#172 (comment).

@alexcrichton
Copy link
Member

I wasn't thinking an RFC per-se, but we don't really have an owner of the design of crates.io now so it's hard to say precisely how to move forward with something like this.

cc @steveklabnik I know you've had thoughts about this in the past.

@steveklabnik
Copy link
Member

Yes, we want to do some visual refresh work, but at the same time, we want to be careful about how we do it. We'll have an internal discussion at some point (I have some work to do first) and go from there. I left this comment on another PR recently:


While it is true that our web properties could use a fresh coat of paint, we're in the very, very beginning stages of considering what that might be like. we'd like to make some functional and content improvements to several of our web sites, but we're currently at the stage of 'organize our thoughts about what should be on the site,' which is before any design can even happen at all.

The core team hopes to have something more to say on the topic soon, but we don't want to commit to anything publicly right now, as we're not sure what the final form of this effort will be.


I don't mind this patch, exactly, but I also don't mind them being square.

@carols10cents
Copy link
Member

I'm going to close this since it's over a year old, and there is another PR that does a UI refresh and would make this moot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants