Remove duplicate initialization of dotenv
#1669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While doing memory profiling, I noticed that `dotenv` was being initialized each time the `env` helper function was called. With my `.env` file in development it was (temporarily) allocating 9.7MB on each call to the `env` helper. The `dotenv::var` helper uses `std::sync::Once` and avoids this duplicate work. I don't expect this to improve allocation patterns on production much, as without a `.env` file, only 1.9kB is (temporarily) allocated.
At most of these call sites in library code, `dotenv` should already be initialized. Most of these changes are for style consistency. Some binaries will initialize sooner and will pick some variables that would not previously work from `.env`.
|
@bors: r+ |
|
📌 Commit afadfb7 has been approved by |
bors
added a commit
that referenced
this pull request
Mar 14, 2019
Remove duplicate initialization of `dotenv` While doing memory profiling, I noticed that `dotenv` was being initialized each time the `env` helper function was called. With my `.env` file in development it was (temporarily) allocating 9.7MB on each call to the `env` helper. The `dotenv::var` helper uses `std::sync::Once` and avoids this duplicate work. I don't expect this to improve allocation patterns on production much/any, as without a `.env` file, only 1.9kB is (temporarily) allocated. Some binaries will initialize sooner and will pick up some variables that would not previously work from `.env`.
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing memory profiling, I noticed that
dotenvwas beinginitialized each time the
envhelper function was called. With my.envfile in development it was (temporarily) allocating 9.7MB oneach call to the
envhelper.The
dotenv::varhelper usesstd::sync::Onceand avoids thisduplicate work. I don't expect this to improve allocation patterns on
production much/any, as without a
.envfile, only 1.9kB is(temporarily) allocated.
Some binaries will initialize sooner and will pick up some variables that
would not previously work from
.env.