Skip to content

Temporarily deny clippy::nursery and fix warnings #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2019

Conversation

jtgeibel
Copy link
Member

@jtgeibel jtgeibel commented Feb 2, 2019

The warnings were ultimately from clippy::needless_borrow and
clippy::redundant_clone.

The warnings were ultimately from `clippy::needless_borrow` and
`clippy::redundant_clone`.
@jtgeibel
Copy link
Member Author

jtgeibel commented Feb 2, 2019

I decided to not leave the #![deny(clippy::nursery)] in the source code for now, but these lints are nice and didn't produce any false positives here.

@sgrif
Copy link
Contributor

sgrif commented Feb 3, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2019

📌 Commit a49c0c2 has been approved by sgrif

@bors
Copy link
Contributor

bors commented Feb 3, 2019

⌛ Testing commit a49c0c2 with merge c0327a3...

bors added a commit that referenced this pull request Feb 3, 2019
Temporarily deny clippy::nursery and fix warnings

The warnings were ultimately from `clippy::needless_borrow` and
`clippy::redundant_clone`.
@bors
Copy link
Contributor

bors commented Feb 3, 2019

☀️ Test successful - checks-travis
Approved by: sgrif
Pushing c0327a3 to master...

@bors bors merged commit a49c0c2 into rust-lang:master Feb 3, 2019
@jtgeibel jtgeibel deleted the clippy-nursery branch February 7, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants