Skip to content

Don't use Diesel CLI 1.0.0 #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Apr 8, 2018

Diesel 1.0.0 was released with overly broad constraints on internal
dependencies. diesel_cli relies on internal implementation details of
diesel (and other internal crates) which are not bound to semver.
Unfortunately, we didn't anticipate the problems that came from having a
"semver compatible" bound on these dependencies when relying on semver
excempt APIs.

This was fixed in Diesel 1.0.1. We could probably just switch to 1.2.0,
but this is the more conservative change.

Fixes our build

Diesel 1.0.0 was released with overly broad constraints on internal
dependencies. `diesel_cli` relies on internal implementation details of
`diesel` (and other internal crates) which are not bound to semver.
Unfortunately, we didn't anticipate the problems that came from having a
"semver compatible" bound on these dependencies when relying on semver
excempt APIs.

This was fixed in Diesel 1.0.1. We could probably just switch to 1.2.0,
but this is the more conservative change.
@sgrif
Copy link
Contributor Author

sgrif commented Apr 8, 2018

@carols10cents Just FYI, all PRs are going to fail CI until this is merged

@sgrif
Copy link
Contributor Author

sgrif commented Apr 8, 2018

I wasn't super clear in the commit message -- The reason this started breaking is due to changes in these APIs in 1.2.0. Everything failing was actually done in a backwards compatible way, but it was done by deprecating the module and macro that are missing, and Diesel CLI does not enable default features on Diesel (which includes the with-deprecated feature)

@Turbo87
Copy link
Member

Turbo87 commented Apr 9, 2018

as this looks like a very minimal and reasonable change and I would like to get the PR CI working again I'm gonna go ahead and merge this :)

@Turbo87 Turbo87 merged commit e612c0f into rust-lang:master Apr 9, 2018
@sgrif sgrif deleted the sg-dont-use-diesel-1.0.0 branch April 10, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants