Don't use Diesel CLI 1.0.0 #1333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diesel 1.0.0 was released with overly broad constraints on internal dependencies. `diesel_cli` relies on internal implementation details of `diesel` (and other internal crates) which are not bound to semver. Unfortunately, we didn't anticipate the problems that came from having a "semver compatible" bound on these dependencies when relying on semver excempt APIs. This was fixed in Diesel 1.0.1. We could probably just switch to 1.2.0, but this is the more conservative change.
|
@carols10cents Just FYI, all PRs are going to fail CI until this is merged |
|
I wasn't super clear in the commit message -- The reason this started breaking is due to changes in these APIs in 1.2.0. Everything failing was actually done in a backwards compatible way, but it was done by deprecating the module and macro that are missing, and Diesel CLI does not enable default features on Diesel (which includes the |
Turbo87
approved these changes
Apr 9, 2018
|
as this looks like a very minimal and reasonable change and I would like to get the PR CI working again I'm gonna go ahead and merge this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diesel 1.0.0 was released with overly broad constraints on internal
dependencies.
diesel_clirelies on internal implementation details ofdiesel(and other internal crates) which are not bound to semver.Unfortunately, we didn't anticipate the problems that came from having a
"semver compatible" bound on these dependencies when relying on semver
excempt APIs.
This was fixed in Diesel 1.0.1. We could probably just switch to 1.2.0,
but this is the more conservative change.
Fixes our build