Fixes #962 Backend: add "most_recently_downloaded" to 'summary' endpoint #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrif
reviewed
Oct 6, 2017
src/krate/mod.rs
Outdated
| @@ -756,6 +756,10 @@ pub fn index(req: &mut Request) -> CargoResult<Response> { | |||
| /// Handles the `GET /summary` route. | |||
| pub fn summary(req: &mut Request) -> CargoResult<Response> { | |||
| use schema::crates::dsl::*; | |||
| use diesel::expression::DayAndMonthIntervalDsl; | |||
| use diesel::types::{BigInt, Nullable}; | |||
| use diesel::expression::functions::date_and_time::{date, now}; | |||
There was a problem hiding this comment.
use diesel::expression::{date, now};
sgrif
reviewed
Oct 6, 2017
src/krate/mod.rs
Outdated
| use diesel::expression::DayAndMonthIntervalDsl; | ||
| use diesel::types::{BigInt, Nullable}; | ||
| use diesel::expression::functions::date_and_time::{date, now}; | ||
| use diesel::expression::sql_literal::sql; |
sgrif
reviewed
Oct 6, 2017
src/krate/mod.rs
Outdated
| ), | ||
| ) | ||
| .group_by(id) | ||
| .order(recent_downloads.clone().desc().nulls_last()) |
There was a problem hiding this comment.
ah, good point. Bad copy pasta.
sgrif
reviewed
Oct 6, 2017
src/tests/krate.rs
Outdated
| @@ -71,6 +82,7 @@ fn new_crate(name: &str) -> u::NewCrate { | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
sgrif
reviewed
Oct 6, 2017
src/tests/krate.rs
Outdated
| let json: SummaryResponse = ::json(&mut response); | ||
|
|
||
| assert_eq!(json.num_crates, 4); | ||
| assert_eq!(json.num_downloads, 0); // need to add a record to metadata |
There was a problem hiding this comment.
Sounds like you need to fix this?
sgrif
reviewed
Oct 6, 2017
src/tests/krate.rs
Outdated
| ); | ||
| assert_eq!(json.popular_keywords[0].keyword, "popular"); | ||
| assert_eq!(json.popular_categories[0].category, "Category 1"); | ||
| assert_eq!(json.just_updated.len(), 0); // update a couple before running this request... |
There was a problem hiding this comment.
Sounds like you need to fix this?
sgrif
reviewed
Oct 8, 2017
src/tests/krate.rs
Outdated
| use self::diesel::prelude::*; | ||
| use serde_json; | ||
| use semver; | ||
| use chrono::Utc; |
sgrif
reviewed
Oct 8, 2017
src/krate/mod.rs
Outdated
| use diesel::expression::DayAndMonthIntervalDsl; | ||
| use diesel::types::{BigInt, Nullable}; | ||
| use diesel::expression::{date, now}; | ||
| use diesel::expression::sql; |
There was a problem hiding this comment.
Can you sort these and squash all the expression imports into one
- add tests for total_downloads and just updated - sort imports
|
bors: r+ |
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds "most_recently_downloaded" property to JSON response returned from
api/v1/summaryAdds tests for
api/v1/summaryendpoint