Skip to content

Add another column to the homepage for "Most Recently Downloaded" #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 of 5 tasks
carols10cents opened this issue Aug 16, 2017 · 11 comments
Closed
3 of 5 tasks
Labels
A-backend ⚙️ A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works E-has-mentor

Comments

@carols10cents
Copy link
Member

carols10cents commented Aug 16, 2017

Instructions for fixing this, can be done in 2 separate PRs but they will need to be done in order :)

PR 1: backend

PR #2: Frontend

  • Once /api/v1/summary returns recent downloads, add a section like these to display recent downloads. Please think of a good header for this, "Most Recently Downloaded" sounds like this is what crates people have downloaded in the last minute? "Most Downloaded in the Last 90 Days" is accurate but long. "Most Recent Downloads"? "Most Downloads Recently"?
  • Check how it looks and at different browser widths; I think the CSS should Just Work but there's a chance it might need some tweaks :)
@carols10cents carols10cents added A-ui C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works labels Aug 17, 2017
@sabinbajracharya
Copy link
Contributor

sabinbajracharya commented Sep 5, 2017

I would like to work on this issue but https://crates.io/api/v1/summary api does not return 'Most recently downloaded' information.

@carols10cents
Copy link
Member Author

Yep, changing the API for the /api/v1/summary route to return this information is part of the issue actually. I got confused and thought #935 was about that, but it's not. Sorry for the misleading tags!

@erewok
Copy link
Contributor

erewok commented Oct 1, 2017

I have created a PR for the backend changes requested here.

I added some tests. However, oddly, when I run cargo test locally, it only runs the tests defined within the modules themselves. I'm trying to figure out how to run all the tests.

@carols10cents
Copy link
Member Author

Hi @erewok!! Glad to have you here!! The behavior you're seeing with cargo test is definitely not expected... how can you tell it's only running the tests in src/krates/mod.rs? Could you gist the whole output you see from cargo test?

@erewok
Copy link
Contributor

erewok commented Oct 4, 2017

Hi @carols10cents. Thanks for the warm welcome! I am impressed with how well-run this project is.

At any rate, this morning I cloned the repo anew, built, and ran the tests and the problem seems to have disappeared. I'm not sure why it was ever there in the first place but it must have been user error. Thanks. I'm going to work on fixing the tests I wrote for the api/v1/summary endpoint.

bors-voyager bot added a commit that referenced this issue Oct 9, 2017
1101: Fixes #962 Backend: add "most_recently_downloaded" to 'summary' endpoint r=sgrif

## Description

- Adds "most_recently_downloaded" property to JSON response returned from `api/v1/summary`

- Adds tests for `api/v1/summary` endpoint
@carols10cents
Copy link
Member Author

The backend for this is now done, thank you @erewok !!!!

@sabinbajracharya
Copy link
Contributor

sabinbajracharya commented Oct 10, 2017

@carols10cents As the backend is done, may I work on the frontend part?

@carols10cents
Copy link
Member Author

@sabinbajracharya absolutely!

sabinbajracharya pushed a commit to sabinbajracharya/crates.io that referenced this issue Oct 10, 2017
sabinbajracharya added a commit to sabinbajracharya/crates.io that referenced this issue Oct 10, 2017
@sabinbajracharya
Copy link
Contributor

#1121

bors-voyager bot added a commit that referenced this issue Oct 18, 2017
1121: [#962] Add "Most Recent Downloads" category r=carols10cents
@someguynamedmatt
Copy link
Contributor

@carols10cents Can this be closed?

@carols10cents
Copy link
Member Author

@someguynamedmatt Indeed! good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works E-has-mentor
Projects
None yet
Development

No branches or pull requests

5 participants