Readme rendering - only rerender older than a date, only rerender for a crate #1010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kureuil
reviewed
Aug 25, 2017
src/bin/render-readmes.rs
Outdated
|
|
||
| let mut page_num = 0; | ||
|
|
||
| for version_ids_chunk in &version_ids.into_iter().chunks(page_size) { |
There was a problem hiding this comment.
I didn't know about itertools, awesome crate!
Couldn't we use enumerate here to remove the mut page_num ?
There was a problem hiding this comment.
oooh yep, you're absolutely right!
kureuil
reviewed
Aug 25, 2017
src/bin/render-readmes.rs
Outdated
| version.num | ||
| ); | ||
| let readme_path = | ||
| format!("readmes/{}/{}-{}.html", krate_name, krate_name, version.num); |
There was a problem hiding this comment.
Should we change the formatting string to "readmes/{0}/{0}-{}.html" to avoid the krate_name duplication ?
kureuil
reviewed
Aug 25, 2017
| version.num | ||
| )); | ||
| }); | ||
| tasks.push(handle); | ||
| } | ||
| for handle in tasks { | ||
| if let Err(err) = handle.join() { | ||
| println!("Thead panicked: {:?}", err); | ||
| println!("Thread panicked: {:?}", err); |
Going to need a Version instead in the next few commits.
This will enable restarting of readme rendering without needing to rerender everything.
This'll make it easier to debug and try fixing particular crates.
carols10cents
force-pushed
the
readme-rerendering-convenience
branch
2 times, most recently
from
d1ecd5d to
fb3f3c6
Compare
carols10cents
force-pushed
the
readme-rerendering-convenience
branch
from
fb3f3c6 to
eee6c09
Compare
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Aug 26, 2017
1010: Readme rendering - only rerender older than a date, only rerender for a crate r=carols10cents Only rerender in a `Box<T>`, only rerender in Firefox :) These changes add some arguments to the render-readmes script to make it easier to restart a failed run only with those readmes that have not been rendered since a particular date, and to rerender one particular crate's readmes. By default, the render-readmes script still rerenders all readmes of all versions. But if the script is killed partway through, it doesn't need to be completely restarted-- you can grab the time that the script printed out that it started, then rerun with `--older-than thattime`, and it'll only try and render the ones it hasn't gotten to yet! Another thing I've wanted is the ability to render one particular crate's readmes, so that I don't have to scroll through all the logs to see why a particular crate failed. So I added the `--crate` argument too. I'd like to get this into the same deploy as #981 since that requires rerendering everything again. @kureuil, could you look over this and see if it looks like I might be breaking anything?
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only rerender in a
Box<T>, only rerender in Firefox :)These changes add some arguments to the render-readmes script to make it easier to restart a failed run only with those readmes that have not been rendered since a particular date, and to rerender one particular crate's readmes.
By default, the render-readmes script still rerenders all readmes of all versions. But if the script is killed partway through, it doesn't need to be completely restarted-- you can grab the time that the script printed out that it started, then rerun with
--older-than thattime, and it'll only try and render the ones it hasn't gotten to yet!Another thing I've wanted is the ability to render one particular crate's readmes, so that I don't have to scroll through all the logs to see why a particular crate failed. So I added the
--crateargument too.I'd like to get this into the same deploy as #981 since that requires rerendering everything again.
@kureuil, could you look over this and see if it looks like I might be breaking anything?