Skip to content

Pagination is strewn around #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Oct 21, 2014 · 4 comments
Closed

Pagination is strewn around #8

alexcrichton opened this issue Oct 21, 2014 · 4 comments
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Comments

@alexcrichton
Copy link
Member

The actual processing code for pagination is refactored into a mixin, but the rendering code is strewn all over mostly because of the need to generate links differently in different contexts:

Examples:
@alexcrichton alexcrichton mentioned this issue Oct 21, 2014
Closed
@wycats
Copy link
Contributor

wycats commented Oct 22, 2014

@stefanpenner @igorT can you take a look at this? What is the "correct" practice for this kind of problem?

@igorT
Copy link

igorT commented Oct 22, 2014

Seems that all the links look the same except for the route name? They could be refactored into a component?

@alexcrichton
Copy link
Member Author

Yeah currently they only differ in how they invoke link-to.

I'm a bit of an ember newb, could you elaborate a little more on what you mean by a component? I think that the pagination itself would be suited well for a component, but how would I pass in parameters for the pagination component to then pass to link-to? In some cases there's also multiple parameters where in others there's just one.

@carols10cents carols10cents added the C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear label Aug 2, 2017
@sgrif
Copy link
Contributor

sgrif commented Jan 24, 2019

We're cleaning out some of the older issues that haven't seen activity lately, so I'm going to close this.

We'd be happy to accept a PR that refactors this code. I'm going to try to open an issue in the next few days with more concrete steps as well.

@sgrif sgrif closed this as completed Jan 24, 2019
carols10cents added a commit to integer32llc/crates.io that referenced this issue Dec 12, 2019
@carols10cents
Fix accessibility problems with the search pagination
1cd9cb5 
The problem was that the next/prev links didn't have any text. For some
reason, the pagination markup on this page was different than, say, that
in crates.hbs. We really should fix rust-lang#8 for real someday.
carols10cents added a commit to integer32llc/crates.io that referenced this issue Dec 12, 2019
@carols10cents
Fix accessibility problems with the search pagination
dfa7ba7 
The problem was that the next/prev links didn't have any text. For some
reason, the pagination markup on this page was different than, say, that
in crates.hbs. We really should fix rust-lang#8 for real someday 😂
carols10cents added a commit to integer32llc/crates.io that referenced this issue Dec 12, 2019
@carols10cents
Fix accessibility problems with the search pagination
9c271e6 
The problem was that the next/prev links didn't have any text. For some
reason, the pagination markup on this page was different than, say, that
in crates.hbs. We really should fix rust-lang#8 for real someday 😂
bors added a commit that referenced this issue Dec 17, 2019
@bors
Auto merge of #1961 - rust-lang:dependabot/npm_and_yarn/ember-compone…
0eec371 
…nt-attributes-0.1.3, r=locks

Bump ember-component-attributes from 0.1.1 to 0.1.3

Bumps [ember-component-attributes](https://github.com/mmun/ember-component-attributes) from 0.1.1 to 0.1.3.
<details>
<summary>Release notes</summary>

*Sourced from [ember-component-attributes's releases](https://github.com/mmun/ember-component-attributes/releases).*

> ## Release 0.1.3
> #### 📝 Documentation
> * [#10](https://github-redirect.dependabot.com/mmun/ember-component-attributes/pull/10) Fix repository field in package.json. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## Release 0.1.2
> No release notes provided.
</details>
<details>
<summary>Changelog</summary>

*Sourced from [ember-component-attributes's changelog](https://github.com/mmun/ember-component-attributes/blob/master/CHANGELOG.md).*

> ## v0.1.3 (2019-06-04)
>
> #### 📝 Documentation
> * [#10](https://github-redirect.dependabot.com/mmun/ember-component-attributes/pull/10) Fix repository field in package.json. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 1
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> ## v0.1.2 (2019-06-04)
>
> #### 🐛 Bug Fix
> * [#8](https://github-redirect.dependabot.com/mmun/ember-component-attributes/pull/8) Update .npmignore to current blueprint default. ([@&#8203;rwjblue](https://github.com/rwjblue))
> * [#7](https://github-redirect.dependabot.com/mmun/ember-component-attributes/pull/7) Exclude .node_modules.ember-try from releases ([@&#8203;chrisseto](https://github.com/chrisseto))
>
> #### 🏠 Internal
> * [#9](https://github-redirect.dependabot.com/mmun/ember-component-attributes/pull/9) Run `npm init rwjblue-release-it-setup` command. ([@&#8203;rwjblue](https://github.com/rwjblue))
>
> #### Committers: 2
> - Chris Seto ([@&#8203;chrisseto](https://github.com/chrisseto))
> - Robert Jackson ([@&#8203;rwjblue](https://github.com/rwjblue))
</details>
<details>
<summary>Commits</summary>

- [`65339e8`](mmun/ember-component-attributes@65339e8) Release 0.1.3
- [`4ad259a`](mmun/ember-component-attributes@4ad259a) Fixup CHANGELOG.md for v0.1.2.
- [`44f68fb`](mmun/ember-component-attributes@44f68fb) Fix repository field in package.json. ([#10](https://github-redirect.dependabot.com/mmun/ember-component-attributes/issues/10))
- [`f881bdf`](mmun/ember-component-attributes@f881bdf) Fix repository field in package.json.
- [`61adb9d`](mmun/ember-component-attributes@61adb9d) Release 0.1.2
- [`7d65917`](mmun/ember-component-attributes@7d65917) Run `npm init rwjblue-release-it-setup` command. ([#9](https://github-redirect.dependabot.com/mmun/ember-component-attributes/issues/9))
- [`ecb0277`](mmun/ember-component-attributes@ecb0277) Run `npm init rwjblue-release-it-setup` command.
- [`eda13d1`](mmun/ember-component-attributes@eda13d1) Remove ember-cli-release.
- [`f1f4031`](mmun/ember-component-attributes@f1f4031) Update .npmignore to current blueprint default. ([#8](https://github-redirect.dependabot.com/mmun/ember-component-attributes/issues/8))
- [`0bb9ee3`](mmun/ember-component-attributes@0bb9ee3) Update .npmignore to current blueprint default.
- Additional commits viewable in [compare view](mmun/ember-component-attributes@v0.1.1...v0.1.3)
</details>
<details>
<summary>Maintainer changes</summary>

This version was pushed to npm by [rwjblue](https://www.npmjs.com/~rwjblue), a new releaser for ember-component-attributes since your current version.
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-component-attributes&package-manager=npm_and_yarn&previous-version=0.1.1&new-version=0.1.3)](https://dependabot.com/compatibility-score.html?dependency-name=ember-component-attributes&package-manager=npm_and_yarn&previous-version=0.1.1&new-version=0.1.3)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
carols10cents added a commit to integer32llc/crates.io that referenced this issue Dec 23, 2019
@carols10cents
Fix accessibility problems with the search pagination
87af1f0 
The problem was that the next/prev links didn't have any text. For some
reason, the pagination markup on this page was different than, say, that
in crates.hbs. We really should fix rust-lang#8 for real someday 😂
@carols10cents carols10cents mentioned this issue Jan 8, 2020
Merged
Turbo87 pushed a commit that referenced this issue Dec 8, 2022
@jtgeibel
Merge pull request #8 from JohnTitor/futures
2f593f4 
Depend on `futures-util` instead of `futures`
Turbo87 pushed a commit that referenced this issue Jan 4, 2023
@jtgeibel
Merge pull request #8 from jtgeibel/use-http-types
d8260cb 
Bump to latest conduit alpha and use `http` types
Turbo87 pushed a commit that referenced this issue Jan 4, 2023
@jtgeibel
Merge pull request #8 from Turbo87/pattern
498c9f5 
Expose the matched route pattern in the request extensions
Turbo87 pushed a commit that referenced this issue Jan 4, 2023
@jtgeibel
Merge pull request #8 from jtgeibel/fix-deprecation
c7be5c4 
Fix deprecation in time crate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend 🐹 C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wycats @alexcrichton @carols10cents @igorT @sgrif