-
Notifications
You must be signed in to change notification settings - Fork 649
e.get is not a function #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The previous one is from Firefox. In Chrome:
|
Does this only happen on the pages of packages that don't exist? |
It seems so. |
cc @rjgoldsborough perhaps related to #421? |
I think it might be this line or related to the afterModel stuff here. The model returns an error when a crate is not found so model.get('description') would fail I believe. |
yeah, that looks to be the case. removing https://github.com/rust-lang/crates.io/blob/master/app/routes/crate.js#L13 fixes the error it seems. |
I think that PR will fix it but would love someone else to confirm. Just checks to make sure model.get is actually a function and model isn't just the error from the above failed promise. I'm not convinced it's the best solution so I'll probably keep poking at it. |
Fixed in #429 Thanks @rjgoldsborough! |
https://crates.io/crates/bert
The stacktrace is:
The text was updated successfully, but these errors were encountered: