Skip to content

Badge alt-text appears to be part of crate title #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SamWhited opened this issue Jan 19, 2018 · 5 comments
Closed

Badge alt-text appears to be part of crate title #1241

SamWhited opened this issue Jan 19, 2018 · 5 comments
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@SamWhited
Copy link

If a badge does not load on crates.io the alt-text is shown but it appears to be part of the surrounding content. It should be distinguished in some way (eg. a smaller colored link). For example, imagine if both badges in the following screenshot had failed to load:

imagetitle

@sgrif
Copy link
Contributor

sgrif commented Jan 19, 2018

This is the behavior of the browser, not crates.io. I don't believe we have any control over this.

@SamWhited
Copy link
Author

SamWhited commented Jan 19, 2018

Could the badges not be moved into spans that are styled differently? Then if the image fails to render they wouldn't appear to be a part of the title.

@nox
Copy link

nox commented Jan 22, 2018

This is definitely in control of crates.io, the badges are in the same <div class=info> as the crate name. Btw, why are those using div elements instead of title-related ones?

@kornelski
Copy link
Contributor

Text styles set on <IMG> affect rendering of the alt text.

@Turbo87
Copy link
Member

Turbo87 commented Apr 28, 2020

closing this issue due to #2440 being merged :)

@Turbo87 Turbo87 closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

6 participants