Skip to content

import project #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

import project #1

merged 1 commit into from
Jun 30, 2025

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Jun 26, 2025 •
edited
Loading

Based on https://github.com/marcoieni/trusted-publishing-action-draft

Docs are in README.md and CONTRIBUTING.md

marcoieni
marcoieni commented Jun 26, 2025
View reviewed changes
marcoieni
marcoieni commented Jun 26, 2025
View reviewed changes
marcoieni
marcoieni commented Jun 26, 2025
View reviewed changes
CONTRIBUTING.md Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if you need more docs here or somewhere else.

@marcoieni marcoieni force-pushed the project-import branch 3 times, most recently from 4a6c4ab to dd0483e Compare June 26, 2025 12:01
marcoieni
marcoieni commented Jun 26, 2025
View reviewed changes
action.yml
@@ -0,0 +1,19 @@
name: "crates-io-auth-action"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the name used in the RFC. Is it fine or you have a better name in mind?

Turbo87
Turbo87 reviewed Jun 26, 2025
View reviewed changes
README.md Outdated
Comment on lines 24 to 28
with:
url: my-registry.example.com
```

Note that the registry must support OpenID Connect authentication.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the RFC we explicitly didn't want to make this part of the offical generic registry API protocol, so we might want to restrict this to staging.crates.io for now. if this happens to work with other registries too, then that's fine, but I'm not sure if we want to officially support that. if we want this to be truly generic then crates-io-auth-action might be the wrong name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased this 👍

Mark-Simulacrum
Mark-Simulacrum reviewed Jun 26, 2025
View reviewed changes
@marcoieni marcoieni force-pushed the project-import branch 13 times, most recently from 77ed45c to 251bd13 Compare June 27, 2025 13:15
@Turbo87 Turbo87 moved this to For next meeting in crates.io team meetings Jun 27, 2025
@marcoieni
Copy link
Member Author

marcoieni commented Jun 27, 2025 •
edited
Loading

There's a bug. The app does too many things in the post job. The package process is broken and some things from main.ts go to post.ts as well. I'll fix this 👍
image

@marcoieni marcoieni force-pushed the project-import branch 2 times, most recently from 18fddaa to 64c6590 Compare June 27, 2025 13:57
@marcoieni marcoieni force-pushed the project-import branch 2 times, most recently from 715a335 to 7ab08b5 Compare June 30, 2025 07:42
@marcoieni
Copy link
Member Author

This morning I tried preventing issues like the one above from happening again, and also to reduce the size of the dist folder, but unfortunately I found out that we are blocked by an issue in the core GitHub library. #5 is tracking this.

I'm merging this now and creating a v1 branch so that people can start using the action. After more people test the action, I'll create the tag v1.0.0.

@marcoieni marcoieni merged commit 05f529d into main Jun 30, 2025
7 checks passed
@Turbo87 Turbo87 mentioned this pull request Jul 1, 2025
Open
19 tasks
@marcoieni marcoieni deleted the project-import branch July 2, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 left review comments

@pietroalbini pietroalbini pietroalbini left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees
No one assigned
Labels
None yet
Projects
crates.io team meetings
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcoieni @Turbo87 @pietroalbini @Mark-Simulacrum