Skip to content

Conversation

@dwijnand
Copy link
Contributor

Wanted to deduplicate the "bar" manifest files too, and found I hadn't even done build.rs.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Look at that diff!

@bors
Copy link
Contributor

bors commented Jul 25, 2018

📌 Commit ab19c48 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 25, 2018

⌛ Testing commit ab19c48 with merge cb9c0b0...

bors added a commit that referenced this pull request Jul 25, 2018
Deduplicate a bunch more manifests in test code

Wanted to deduplicate the "bar" manifest files too, and found I hadn't even done build.rs.
@bors
Copy link
Contributor

bors commented Jul 25, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cb9c0b0 to master...

@bors bors merged commit ab19c48 into rust-lang:master Jul 25, 2018
bors added a commit that referenced this pull request Jul 25, 2018
Declare one-line files on one line, in test projects

Builds on #5787
Fixes #5745 unless @alexcrichton feels more can be done there.
@dwijnand dwijnand deleted the dedup-manifest-further branch July 25, 2018 22:05
@ehuss ehuss added this to the 1.29.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants