Don't attempt to read a token from stdin if a cmdline token is provided #12440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-interacts-with-crates.io
weihanglo
approved these changes
Aug 3, 2023
Member
weihanglo
left a comment
weihanglo
left a comment
There was a problem hiding this comment.
Thanks!
I am not sure how to write a test for this. If you come up with a way to have a proper test please submit another PR :)
I'll merge this now.
Member
|
@bors r+ |
Contributor
bors
added
S-waiting-on-bors
Contributor
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 3, 2023
Update cargo (CVE-2023-38497 fix included) 2 commits in 020651c52257052d28f6fd83fbecf5cfa1ed516c..d78bbf4bde3c6b95caca7512f537c6f9721426ff 2023-08-02 16:00:37 +0000 to 2023-08-03 12:58:25 +0000 - Fix CVE-2023-38497 for master (rust-lang/cargo#12443) - Don't attempt to read a token from stdin if a cmdline token is provided (rust-lang/cargo#12440) r? `@ghost`
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12438