Skip to content

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Apr 28, 2022

Tracking issue: #8415
RFC: rust-lang/rfcs#2906

This updates documentation about workspace inheritance in the Cargo Book. This is meant to move the documentation into a state that is acceptable to move after stabilization. It currently proposes adding sections to workspaces.md and specifying-dependencies.md.

r? @epage

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2022
@Muscraft Muscraft force-pushed the workspace-inheritance-documentaion branch from 8938194 to 52476d0 Compare April 28, 2022 16:04
@Muscraft Muscraft changed the title Move documentation for workspace inheritance from unstable Update documentation for workspace inheritance Apr 28, 2022
@Muscraft Muscraft marked this pull request as ready for review April 28, 2022 16:07
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this written up!

@Muscraft Muscraft force-pushed the workspace-inheritance-documentaion branch from 52476d0 to dbf05b2 Compare April 28, 2022 18:15
Copy link
Contributor

@epage epage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is always the hardest part but we're getting closer!

@Muscraft Muscraft force-pushed the workspace-inheritance-documentaion branch from dbf05b2 to 28fae8d Compare April 28, 2022 19:07
@Muscraft Muscraft force-pushed the workspace-inheritance-documentaion branch from 28fae8d to 9ed3276 Compare April 28, 2022 19:20
@epage
Copy link
Contributor

epage commented Apr 28, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 28, 2022

📌 Commit 9ed3276 has been approved by epage

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2022
@bors
Copy link
Contributor

bors commented Apr 28, 2022

⌛ Testing commit 9ed3276 with merge e019061...

@bors
Copy link
Contributor

bors commented Apr 28, 2022

☀️ Test successful - checks-actions
Approved by: epage
Pushing e019061 to master...

@bors bors merged commit e019061 into rust-lang:master Apr 28, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2022
Update cargo

7 commits in f63f23ff1f1a12ede8585bbd1bbf0c536e50293d..a44758ac805600edbb6ba51e7e6fb81a6077c0cd
2022-04-28 03:15:50 +0000 to 2022-05-04 02:29:34 +0000
- Add support for `-Zbuild-std` to `cargo fetch` (rust-lang/cargo#10129)
- Migrate tests of `cargo-init` to snapbox (rust-lang/cargo#10620)
- dedupe toml_edit crate, followup rust-lang/cargo#10603 (rust-lang/cargo#10619)
- Update GitHub Actions actions/checkout@v2 to v3 (rust-lang/cargo#10618)
- Integrate snapbox in with cargo-test-support (rust-lang/cargo#10581)
- Fix zsh completion (rust-lang/cargo#10613)
- Update documentation for workspace inheritance (rust-lang/cargo#10611)
@ehuss ehuss added this to the 1.62.0 milestone May 20, 2022
@Muscraft Muscraft deleted the workspace-inheritance-documentaion branch May 27, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants