Make the blogs highlight style inline with the website #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Does the change on phone still produce the same ouptput? |
|
|
|
I don't think I'm a good assignee here! r? @Manishearth perhaps? |
|
As I mentioned in rust-lang/www.rust-lang.org#1165 , I believe the highlight style chosen here was a deliberate choice. I've seen this kind of styling before across the web. |
|
Given that there's positive review on the website topic (rust-lang/www.rust-lang.org#1165 (comment)), I assume this one is good, too. |
skade
approved these changes
Jul 6, 2020
|
Yep, but this shouldn’t be merged yet, the www PR needs to merge and then the website needs to be deployed so that the change happens simultaneously. I also have to make a PR to thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR to rust-lang/www.rust-lang.org#1165
Production
Proposed