Minor gimli cleanup
#666
Merged
Minor gimli cleanup
#666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CraftSpider
force-pushed
the
improve-in-std
branch
from
cda8d07 to
dc02f37
Compare
Comment on lines
+352
to
+440
| path.push(char::from_digit((build_id[0] >> 4) as u32, 16)?); | ||
| path.push(char::from_digit((build_id[0] & 0xf) as u32, 16)?); |
There was a problem hiding this comment.
Hmm, this is significantly noisier in practice... I think I'd prefer to keep fn hex.
|
I'll fix conflict when I have a moment. Sorry for not updating yet - doing real life stuff over the weekend. |
|
that's fine! I actually was speaking up because I would recommend you not update this until after #662 lands... |
CraftSpider
force-pushed
the
improve-in-std
branch
from
cfd94f5 to
b9e231e
Compare
Merged
workingjubilee
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while considering
backtrace_in_libstd. Figured it was worth making it more clear which imports needed std, and removing some pointless casting and such.