-
Notifications
You must be signed in to change notification settings - Fork 45
Closed
Labels
M-breaking-changeMeta: Implementing or merging this will introduce a breaking changeMeta: Implementing or merging this will introduce a breaking change
Milestone
Description
Currently, SourceAnnotation
's range
field is based on chars, not bytes. This can be a little confusing for users and can cause issues when dealing with spans from things like toml
errors. It would make more sense to have users give us bytes, and we calculate the char spans internally. This would make the API easier to use as most people can handle going to bytes, but going from bytes -> chars can be very hard.
plusvic and b4D8PatchMixolydic
Metadata
Metadata
Assignees
Labels
M-breaking-changeMeta: Implementing or merging this will introduce a breaking changeMeta: Implementing or merging this will introduce a breaking change