Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Conversation

sourcefrog
Copy link
Contributor

On Dash run from zsh on Debian, $SHELL can be just 'sh' which causes the
platform to be incorrectly assumed to be i686 even when it's actually
64-bit.

On Dash run from zsh on Debian, $SHELL can be just 'sh' which causes the
platform to be incorrectly assumed to be i686 even when it's actually
64-bit.
@sourcefrog
Copy link
Contributor Author

I hit a similar problem to in rust-lang/rust#17850

@sourcefrog
Copy link
Contributor Author

we could instead do which $SHELL but this seemed like the safest change

@sourcefrog
Copy link
Contributor Author

I should probably change the following if to -e too: we shouldn't conclude we're 32-bit just because we can't find a file to examine.

@sourcefrog
Copy link
Contributor Author

@brson @alexcrichton not sure if you're subscribed to rustup - could you have a look?

brson added a commit that referenced this pull request Jul 6, 2015
Handle $SHELL being set but not an absolute path.
@brson brson merged commit cca2cb6 into rust-lang-deprecated:master Jul 6, 2015
@brson
Copy link
Contributor

brson commented Jul 6, 2015

@sourcefrog Sorry, I've been away from the Internet. Thank you for the good fix.

@brson
Copy link
Contributor

brson commented Jul 6, 2015

I deployed this to static.rlo and upgraded multirust.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants