Skip to content

Newsletter 11: Add KatharosTech on GitHub Sponsors #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2020
Merged

Newsletter 11: Add KatharosTech on GitHub Sponsors #176

merged 1 commit into from
Jul 4, 2020

Conversation

zicklag
Copy link
Contributor

@zicklag zicklag commented Jun 30, 2020 •
edited by ozkriff
Loading

Part of #172 ("Newsletter 11: Coordination/Tracking")

@zicklag zicklag changed the title Add KatharosTech on GitHub Sponsors Newsletter 11: Add KatharosTech on GitHub Sponsors Jun 30, 2020
ozkriff
ozkriff reviewed Jul 3, 2020
View reviewed changes
ozkriff
ozkriff requested changes Jul 3, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me that atm the section is somewhat too focused on donations. Could you include a few lines with a summary/overview of the updates/plans?

Also, insert line breaks (softbreak) at 80 chars, please.

@ozkriff ozkriff requested review from 17cupsofcoffee and kvark July 3, 2020 18:21
@ozkriff ozkriff mentioned this pull request Jul 3, 2020
Closed
43 tasks
@zicklag
Copy link
Contributor Author

zicklag commented Jul 3, 2020 •
edited
Loading

Absolutely. I reworded it quite a bit focusing on the vision and plan for development, is this too wordy/long?

@zicklag zicklag requested a review from ozkriff July 3, 2020 23:26
@ozkriff
Copy link
Member

ozkriff commented Jul 4, 2020

Nice! We're trying to avoid h4 headers in general: could you remove the subheaders, please?

Like this

image

Also, could you resolve conflicts, please?

I'd do the formatting tweaks and conflict resolution myself but the "Allow edits from maintainers" checkbox in this PR seems to be unselected.

@zicklag
Copy link
Contributor Author

zicklag commented Jul 4, 2020

I'd do the formatting tweaks and conflict resolution myself but the "Allow edits from maintainers" checkbox in this PR seems to be unselected.

That's strange, the checkbox is normally checked by default, and now I don't even see it. Maybe it is because it is from my organization repo or something. Anyway I made the changes. :)

ozkriff
ozkriff approved these changes Jul 4, 2020
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ozkriff ozkriff merged commit d49b111 into rust-gamedev:source Jul 4, 2020
@ozkriff
Copy link
Member

ozkriff commented Jul 4, 2020

Merged, thanks for the PR! :)

@zicklag zicklag deleted the arsenal-update branch July 4, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee Awaiting requested review from 17cupsofcoffee

@kvark kvark Awaiting requested review from kvark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zicklag @ozkriff