add the embedonomicon #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @japaric, I plan to take a look at this, and hopefully add the CI for both projects tomorrow (Saturday). It has been a busy week :) |
|
Hey @japaric, Generally LGTM, a couple thoughts moving forward (I'll open up a follow on PR for this):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this imports japaric/embedonomicon#89f59ff074f37e3d378be191d34362abaf0ebd01 into this repository
I selected CC0 for the text of the embedonomicon but I'd be happy to change the text license to
CC-BY-SA for consistence. (IANAL, but AIUI anyone can relicense CC0 stuff as CC-BY-SA anyways)
r? @jamesmunns