Skip to content

Conversation

@japaric
Copy link
Member

@japaric japaric commented Jan 6, 2019

DCC (Debug Communication Channel) is a debug interface similar to Cortex-M's
ITM.

r? @rust-embedded/cortex-r

…team

DCC (Debug Communication Channel) is a debug interface similar to Cortex-M's
ITM.
@japaric japaric requested review from a team, dylanmckay and jcsoo as code owners January 6, 2019 09:10
@japaric japaric added needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged T-cortex-r labels Jan 6, 2019
@japaric japaric mentioned this pull request Jan 6, 2019
@thejpster
Copy link
Contributor

Oh. Where I'm from, DCC is the official standard for digitally controlling model trains. Can we call this cortex-dcc or arm-dcc or debug-comm-channel, or something?

@paoloteti
Copy link

DCC = Dual-Clock Comparator on lockstep ARM devices. So, even if DCC is vendor specific and not from ARM, arm-dcc may be is not the best name too.

@eddyp
Copy link

eddyp commented Jan 7, 2019

But this code would support the arm/cortex implementation of dcc, so it should be OK, right?
BTW, I consider it a design flaw that cargo has a flat name space since name collisions can occur really easily. For instance, there is a git tool that predates Linus' vcs...

@japaric
Copy link
Member Author

japaric commented Jan 12, 2019

@thejpster if your goal is having the dcc crate be something DCCTRAIN related
I would suggest reserving the name on crates.io since anyone is free to take it.

Using arm-dcc seems fine to me. Debug Communication Channel is an ARM thing
since ARM7 / ARM9.

@paoloteti isn't Dual-Clock Comparator a TI specific thing? It doesn't show up
in https://developer.arm.com . If that deserves its own crate it could be named
ti-dcc.

At the end the name doesn't really tell you what the crate is about, the crate
description does.

I don't have a strong opinion on this one so I leave the decision up to
@paoloteti, the only other Cortex-R team member.

@paoloteti
Copy link

LGTM. Let's use arm-dcc

paoloteti
paoloteti previously approved these changes Jan 12, 2019
@japaric
Copy link
Member Author

japaric commented Jan 22, 2019

Renamed dcc to arm-dcc in the README.

@paoloteti you'll have to approve this PR again.

@japaric
Copy link
Member Author

japaric commented Jan 22, 2019

bors r=paoloteti

@bors
Copy link
Contributor

bors bot commented Jan 22, 2019

👎 Rejected by label

@japaric japaric removed the needs-decision This RFC or PR needs to be approved by the majority of reviewers before it's merged label Jan 22, 2019
@japaric
Copy link
Member Author

japaric commented Jan 22, 2019

sudo
bors r=paoloteti

bors bot added a commit that referenced this pull request Jan 22, 2019
287: add cortex-r, dcc and panic-dcc to crates maintained by the cortex-r team r=paoloteti a=japaric

DCC (Debug Communication Channel) is a debug interface similar to Cortex-M's
ITM.

r? @rust-embedded/cortex-r

Co-authored-by: Jorge Aparicio <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 22, 2019

Build succeeded

@bors bors bot merged commit 5d1d6c7 into master Jan 22, 2019
@bors bors bot deleted the dcc branch January 22, 2019 10:33
@japaric
Copy link
Member Author

japaric commented Jan 22, 2019

The arm-dcc repository has been moved into the org: https://github.com/rust-embedded/arm-dcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants