Skip to content

Refactor fields #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2019
Merged

Refactor fields #333

merged 3 commits into from
Jul 25, 2019

Conversation

burrbull
Copy link
Member

Non-breaking change.

r? @therealprof

@burrbull burrbull requested a review from a team as a code owner July 25, 2019 07:21
@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jul 25, 2019
therealprof
therealprof approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring! Review was a bit hard because it shuffles the order around quite a bit but it's actually very nice to have the read proxies right next to the write proxies for the same field.

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jul 25, 2019
@bors @burrbull
Merge #333
fde8568 
333: Refactor fields r=therealprof a=burrbull

Non-breaking change.

r? @therealprof 

Co-authored-by: Andrey Zgarbul <[email protected]>
@therealprof
Copy link
Contributor

@burrbull For the future: Please avoid merging in changes from the master branch (or anywhere else) and rebase your change instead to keep the history clean.

@bors
Copy link
Contributor

bors bot commented Jul 25, 2019

Build succeeded

@bors bors bot merged commit 95038d9 into rust-embedded:master Jul 25, 2019
@burrbull burrbull deleted the refactor-fields branch July 25, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @therealprof @rust-highfive