Skip to content

[WIP] bump nix to 0.14 to fix libc issues #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[WIP] bump nix to 0.14 to fix libc issues #15

wants to merge 1 commit into from

Conversation

ryankurte
Copy link

@ryankurte ryankurte commented May 22, 2019

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @posborne (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ryankurte
Copy link
Author

this, looks like it's gonna need some updating...

error: cannot find macro `ioctl!` in this scope
   --> src/spidevioctl.rs:126:5
    |
126 |     ioctl!(read get_mode_u8 with SPI_IOC_MAGIC, SPI_IOC_NR_MODE; u8);
    |     ^^^^^

error[E0425]: cannot find function `set_mode_u32` in module `ioctl`
   --> src/spidevioctl.rs:164:46
    |
164 |         try!(from_nix_result(unsafe { ioctl::set_mode_u32(fd, &mode.bits) }));
    |                                              ^^^^^^^^^^^^ not found in `ioctl`

error[E0425]: cannot find function `set_mode_u8` in module `ioctl`
   --> src/spidevioctl.rs:167:46
    |
167 |         try!(from_nix_result(unsafe { ioctl::set_mode_u8(fd, &bits) }));
    |  

error[E0425]: cannot find function `get_lsb_first` in module `ioctl`
   --> src/spidevioctl.rs:174:42
    |
174 |     try!(from_nix_result(unsafe { ioctl::get_lsb_first(fd, &mut lsb_first) }));
    |                                          ^^^^^^^^^^^^^ not found in `ioctl`
help: possible candidate is found in another module, you can import it into scope
    |
11  | use spidevioctl::get_lsb_first;
    |

...

@ryankurte ryankurte changed the title bump nix to 0.14 to fix libc issues [WIP] bump nix to 0.14 to fix libc issues May 22, 2019
@posborne
Copy link
Member

@ryankurte I can take a look at resolving this. I'm a a maintainer on nix and the original author of some of the ioctl abstrations. There were some changes in recent versions that change the macros. Should be easy enough to address to get to 0.14.

@posborne posborne mentioned this pull request May 29, 2019
@ryankurte
Copy link
Author

closing in favour of #16

@ryankurte ryankurte closed this May 29, 2019
@ryankurte ryankurte deleted the fix/nix-0.14 branch June 23, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants