-
Notifications
You must be signed in to change notification settings - Fork 46
Update embedded-hal to 1.0.0-alpha.8 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ryankurte (or someone else) soon. Please see the contribution instructions for more information. |
Looks like embedded-hal 1.0.0-alpha.8 uses |
Hello, is there any progress on this? |
Thanks for the reminder. |
ee5b7da
to
21dbc04
Compare
Ok, 1.54.0 it is! |
Thanks! |
21dbc04
to
63f559d
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this looks good to me, although the transfer_in_place
is actually fake since it copies the buffer.
We could also add the small piece of unsafe code we had back some day if this is a problem for somebody, though.
Could you also add an entry to the changelog?
This also bumps the MSRV to 1.54.0, as this is embedded-hal's current requirement.
63f559d
to
19749d5
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
bors r+
84: Prepare 0.4.0-alpha.3 release r=ryankurte a=eldruin Now that #83 is in, it would be good to publish a new alpha release. Co-authored-by: Diego Barrios Romero <[email protected]>
No description provided.